----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37087/#review94097 -----------------------------------------------------------
api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 255) <https://reviews.apache.org/r/37087/#comment148593> Drive-by partial feedback. This needs to stick to field ID 2, otherwise backwards compatibility is broken. - Bill Farner On Aug. 4, 2015, 5:52 p.m., Dan Norris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37087/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 5:52 p.m.) > > > Review request for Aurora, Jake Farrell and Bill Farner. > > > Bugs: AURORA-1396 > https://issues.apache.org/jira/browse/AURORA-1396 > > > Repository: aurora > > > Description > ------- > > Add all Docker options supported by Mesos. > > Specifically, this enables you to pass the following options to a Docker > object: > - Docker networking modes > - Privileged mode > - Force pull images > - Docker port mapptings > > This also updates the ordering in the Docker struct in Thrift to match the > Mesos protobuf message. > > Tickets covered: AURORA-1396, AURORA-1057, AURORA-1095. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > f792be0ad393072b4a4ec525363e06cfd16b63d0 > docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 > examples/vagrant/upstart/aurora-scheduler.conf > 789a3a0315e8530880999432aa9b1e7d0f57d1ff > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 1903315c0753c68fd1e103d48fff037ba59b7642 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > 4562b3b8546be152e697412e9b9ed5e3b18aba16 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java > 27f1f33ffc782b3d2a2a9add494c04911659e217 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java > afb66c5f79c08c966807c403b334e8589126f2fe > > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/DockerNetworkingModeTypeHandler.java > PRE-CREATION > src/main/python/apache/aurora/config/schema/base.py > 214d5594a2c22e92d5412e40c2ddf18e65c2af63 > src/main/python/apache/aurora/config/thrift.py > adf53bb1c28d61e9bcb670c60f293cf8262c5836 > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml > bfad339a84c6ca87bc6fea339af10a559d8eb3d5 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 7634047abaec9129ee9ead08cc51a10b3261515d > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > fc44389ee07de3dba258d04c65c5bfff13e4eef9 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > b231827ff7fdb2aa37580a32cae74d5da17c2f97 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > 7f18bbc4359306d2a2bb68b13d9853686714e441 > src/test/python/apache/aurora/config/test_thrift.py > 061864eb475807332d328fa72f35f179d36ef9e8 > > Diff: https://reviews.apache.org/r/37087/diff/ > > > Testing > ------- > > Ran build-support/jenkins/build.sh and the e2e tests in Vagrant. > > > Thanks, > > Dan Norris > >
