----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37141/#review94310 -----------------------------------------------------------
Ship it! Ship It! - Maxim Khutornenko On Aug. 5, 2015, 8:51 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37141/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 8:51 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > This additional `@Transactional` renders the inner transaction useless, and > results in async work still being performed within the transaction. > > I neglected to remove this in https://reviews.apache.org/r/37049/, and also > neglected to validate that patch against the environment where i've been able > to trigger the issue. With this patch, the `IllegalArgumentException` is > fixed. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java > aac62e2bbc212f61e61ffca75753ef06f1701ea4 > > Diff: https://reviews.apache.org/r/37141/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
