----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624/#review95990 -----------------------------------------------------------
Ship it! LGTM, just rebase and wait for an all clear from reviewbot. - Zameer Manji On Aug. 19, 2015, 4:49 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37624/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 4:49 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1418 > https://issues.apache.org/jira/browse/AURORA-1418 > > > Repository: aurora > > > Description > ------- > > Preemption filter now ignores revocable offers but still considers revocable > task non-compressible resources. > > Will not apply, diffed against https://reviews.apache.org/r/37593. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java > 8162323816aedc711a3af84cd499250b78718ab3 > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java > a0e71e1c74f67b8836e7da5418012f342977f661 > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java > 66f20c6a63b331353c467cde5521f21e4df49e2d > > Diff: https://reviews.apache.org/r/37624/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
