> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > build-artifact.sh, line 40 > > <https://reviews.apache.org/r/37107/diff/3/?file=1032754#file1032754line40> > > > > realpath wasn't available in our vanilla Vagrant environment. Perhaps > > add a check and/or apt-get it? > > Bill Farner wrote: > It feels strange to make the `aurora` repo's Vagrantfile preconfigured > for this tooling. The bit of docker setup was fine since it was sort of a > broken docker installation. Leaking dependencies in sets a different > precedent though. To an extent, it's strange to use vagrant at all since it > defeats some of the purpose of using Docker. If we provide a Vagrantfile at > all, it should really be in this repo now. Do you have any thoughts on this > perspective? > > Maxim Khutornenko wrote: > Using Vagrant seems the most straighforward path towards building > packages on OSX given the infrastucture we already have in place. This is > also the approach used by some of our build scripts (e.g. > make-mesos-native-egg). Other alternatives assume installing extras like > Docker Toolbox. Not unreasonable at all but feels strange to ignore > infrastructure we already use for e2e tests and python deps. > > I'd also suggest adding a "readme.md" exlaining platform requrements and > giving basic overview of the process.
Added an initial README.md. We can tackle the vagrant discussion separately. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review94760 ----------------------------------------------------------- On Aug. 5, 2015, 5:32 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37107/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 5:32 p.m.) > > > Review request for Aurora, Benjamin Staffin, Maxim Khutornenko, and Steve > Salevan. > > > Bugs: AURORA-1410 > https://issues.apache.org/jira/browse/AURORA-1410 > > > Repository: aurora-packaging > > > Description > ------- > > There's definitely more work to be done here, but this is my proposed > structure. > > Noteworthy files/dirs: > - `/specs`: package build specifications > - `/builder`: build environments and scripts > - `/build-artifact.sh`: build tool and definition of the 'contract' that > builders must adhere to > > To make this work, i had to make some changes to the package defs we have: > - **deb and rpm**: reverted some post-0.9.0 build target changes, so i could > build 0.9.0 packages > - **rpm**: removed fetch/build of mesos to produce eggs, using our dists on > svn instead > > > **Note** - this is my first time playing with docker, `rpmbuild`, and > `dpkg-buildpackage`. Be gentle, but don't hesitate to point out mistakes i'm > making! > > > Diffs > ----- > > .gitignore PRE-CREATION > build-artifact.sh PRE-CREATION > builder/deb/ubuntu-trusty/Dockerfile PRE-CREATION > builder/deb/ubuntu-trusty/build.sh PRE-CREATION > builder/rpm/centos-7/Dockerfile PRE-CREATION > builder/rpm/centos-7/build.sh PRE-CREATION > builder/rpm/centos-7/pants.ini PRE-CREATION > specs/debian/pants.ini > specs/debian/rules d9814008e749c5dee3c6b0a7d0d852e123e29987 > specs/rpm/Makefile 1833a25f5040efdaf62b2c95c97b027acc09fef8 > specs/rpm/aurora.spec 5ec516f0cedaa5a1944c513d6303f4ce58d0bcd2 > > Diff: https://reviews.apache.org/r/37107/diff/ > > > Testing > ------- > > Successfully ran: > ``` > ./build-artifact.sh builder/deb/ubuntu-trusty > ~/Downloads/apache-aurora-0.9.0.tar.gz > ./build-artifact.sh builder/rpm/centos-7 > ~/Downloads/apache-aurora-0.9.0.tar.gz > ``` > > I have no idea if the rpms or debs produced _work_, but they are created. I > will follow up after actually trying to use them. > > > Thanks, > > Bill Farner > >
