> On Aug. 24, 2015, 8 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > <https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29> > > > > Revert? > > Maxim Khutornenko wrote: > There was a `production = True` kvarg added that required to reformat > here. This is to enforce production behavior in view of the current and > upcoming tier-related work. > > Bill Farner wrote: > What's not clear is why our tutorial has to change for this.
We use `environment = 'prod'` but don't set the production flag thus defaulting to non-prod behavior. This change fixes the oversight and delivers on naming expectations. Nothing else in the tutorial has to change. > On Aug. 24, 2015, 8 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 191 > > <https://reviews.apache.org/r/37719/diff/1/?file=1048465#file1048465line191> > > > > consider `NOT NULL` here, and apply the implicit tier=defaut behavior > > in the scheduler. > > Maxim Khutornenko wrote: > I thought about that but ruled it out in the end. If applied, the default > will make it impossible to run non-prod tasks with regular (non-revocable) > resources. The default 'noop' resource estimator in Mesos (1) does not send > any revocable offers. Thus, we need a tri-state here to try out > oversubscription and gradually move towards revocable-only usage for non-prod > tasks. > > Once we are confident oversubscription works as intended (later in 0.10.0 > or even 0.11.0) we'll make the switch to use tier-default everywhere (both > client schema and scheduler). Makes sense? > > (1) - > https://github.com/apache/mesos/blob/f68661e75b8fd09311e0fcd057e34ae836e30f94/docs/oversubscription.md > > Bill Farner wrote: > Perhaps i'm missing something...isn't the idea that server-side tier > definitions allow this type of configuration? I recognize the need for >=3 > states, but i figured that would be handled with different/varying tier > definiitions. | Perhaps i'm missing something...isn't the idea that server-side tier definitions allow this type of configuration? Correct. This is the long(er) term view. It does not have to be tied to this feature though. We need to design and carefully orchestrate that client/env -> server/tier migration making sure we deprecate things gracefully. I expect to address this shortly after this feature is complete. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96185 ----------------------------------------------------------- On Aug. 24, 2015, 5:32 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37719/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 5:32 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1414 > https://issues.apache.org/jira/browse/AURORA-1414 > > > Repository: aurora > > > Description > ------- > > Added support for 'tier' in schema and thrift. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > f792be0ad393072b4a4ec525363e06cfd16b63d0 > examples/jobs/hello_world.aurora 5401bfebe753b5e53abd08baeac501144ced9b5a > src/main/java/org/apache/aurora/scheduler/TierManager.java > ebfad9788a65fbfb7790e40db4a47a6a570b4a7b > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 1903315c0753c68fd1e103d48fff037ba59b7642 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > d103d19b30c5e219c385018d26d6872464520380 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java > 956c508b163cadb13858f7ac0fbc7a971c2cc770 > src/main/python/apache/aurora/client/config.py > 59703ef18c61dbed635954e05a38385ac364b679 > src/main/python/apache/aurora/config/schema/base.py > 214d5594a2c22e92d5412e40c2ddf18e65c2af63 > src/main/python/apache/aurora/config/thrift.py > adf53bb1c28d61e9bcb670c60f293cf8262c5836 > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml > bfad339a84c6ca87bc6fea339af10a559d8eb3d5 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 7634047abaec9129ee9ead08cc51a10b3261515d > src/test/java/org/apache/aurora/scheduler/TierManagerTest.java > 37e19ac71b0f1da7b8a0c06137e43d2143302d85 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > b231827ff7fdb2aa37580a32cae74d5da17c2f97 > src/test/python/apache/aurora/client/cli/test_create.py > 69039b6c0504c9d14a96693249c7199958aadc96 > src/test/python/apache/aurora/client/test_config.py > 986061bf0829caa0509416a3de1778c2fa40a766 > src/test/python/apache/aurora/config/test_thrift.py > 061864eb475807332d328fa72f35f179d36ef9e8 > > Diff: https://reviews.apache.org/r/37719/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants test.pytest --no-fast src/test/python:: > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Maxim Khutornenko > >
