----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37731/#review96221 -----------------------------------------------------------
Ship it! build-artifact.sh (line 30) <https://reviews.apache.org/r/37731/#comment151543> For the RPM spec consider making this argument an explicit command-line flag (with `--define`) rather than an environment variable. - Kevin Sweeney On Aug. 24, 2015, 3:02 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37731/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 3:02 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-1410 > https://issues.apache.org/jira/browse/AURORA-1410 > > > Repository: aurora-packaging > > > Description > ------- > > This allows the builder to set the aurora version number. The > `AURORA_VERSION` environment variable is already read by the RPM spec. > > > Diffs > ----- > > README.md e45f22fed3a7a6d04db08481d2d87bf22ebfdd1a > build-artifact.sh e6ea723331db34e8d0e8462c7cdbf66ec4d4814e > builder/deb/ubuntu-trusty/build.sh 6bee0e7bd7fe81682b583041cf9ae32bfaec33f0 > > Diff: https://reviews.apache.org/r/37731/diff/ > > > Testing > ------- > > ``` > ./build-artifact.sh \ > builder/deb/ubuntu-trusty \ > ~/Downloads/apache-aurora-0.9.0.tar.gz \ > 0.9.0 > ``` > > > Thanks, > > Bill Farner > >
