----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97195 -----------------------------------------------------------
examples/vagrant/upstart/mesos-slave.conf (line 38) <https://reviews.apache.org/r/37926/#comment152991> any reason for the verbosity? Why not just 'fixed_estimator' or something equally brief? src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora (line 1) <https://reviews.apache.org/r/37926/#comment152993> Seems like there's an opportunity to dogfood our DSL a bit more here and describe multiple jobs in the same .aurora files, augmenting specific fields. Can you take that approach? src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (line 322) <https://reviews.apache.org/r/37926/#comment152992> We probably only want to create a job using revocable resources and watch that it doesn't explode. The full extra round of test cases seems excessive. - Bill Farner On Aug. 31, 2015, 3:53 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37926/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 3:53 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Also, had to backout client tier validation added earlier until the feature > exits beta. > > > Diffs > ----- > > examples/vagrant/upstart/aurora-scheduler.conf > e909451892f117e9e6eb80994079661827a0914c > examples/vagrant/upstart/mesos-slave.conf > 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639 > src/main/java/org/apache/aurora/scheduler/http/Offers.java > 4329ce10189df41a7a45cd6cc369333d7d5f65b0 > src/main/python/apache/aurora/client/config.py > f5ac084ae5b448221363add9476334742b217b92 > src/test/python/apache/aurora/client/test_config.py > 37459f5218e76fac831601806a0331927c0ee2c0 > src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora > PRE-CREATION > > src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora > PRE-CREATION > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > 018efbe43de0c829799bc2f789958c55b1cb61a4 > > Diff: https://reviews.apache.org/r/37926/diff/ > > > Testing > ------- > > > Thanks, > > Maxim Khutornenko > >
