----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97319 -----------------------------------------------------------
Reviewer notes commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java <https://reviews.apache.org/r/38014/#comment153157> This is replaced by invoking the @AppStartup service manager in SchedulerMain. commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java <https://reviews.apache.org/r/38014/#comment153158> This was moved to SchedulerMain commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java <https://reviews.apache.org/r/38014/#comment153159> TimeSeriesRepositoryImpl is now a service commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java <https://reviews.apache.org/r/38014/#comment153160> I don't think there's much value behind gating sampling here while shutting down. src/main/java/org/apache/aurora/GuavaUtils.java (lines 115 - 124) <https://reviews.apache.org/r/38014/#comment153161> Moved this from AppModule, but i'm not convinced it's valuable. It seems to suggest that we don't have confidence in logging elsewhere in the scheduler about why we are tearing down. src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java <https://reviews.apache.org/r/38014/#comment153162> This is now done in SchedulerMain. - Bill Farner On Sept. 1, 2015, 11:42 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38014/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 11:42 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Remove StartupRegistry. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java > 78ed7d0aae50c976eba9045b17587258edc588b0 > > commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java > 997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f > > commons/src/main/java/org/apache/aurora/common/application/StartupStage.java > 80509010f37894108881d40cad9d8ade8610f309 > > commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java > 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 > > commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java > 3959ce3d688dd50399185925d91f0014fc1c43f9 > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java > 6928e48073d152915ca42b6f46236b21c0882086 > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java > 387e379a9c84d663f2af23e4760754a023219860 > config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 > src/main/java/org/apache/aurora/GuavaUtils.java > e3e90e3e43744463a2f00552f0041d0d1945bd57 > src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java > 1077816b696c4d2e97aafa59900b6acf2adce064 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 6892a70042e25fd672475517325b4e4b69a0adab > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 8047622e206c9827e5cd8e40152a278d495bd0ff > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 1a25924d789295c5950947f5e302e1d1fbec68f2 > > src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java > 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 > src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java > cb38c3e047efac483445f43b941c7eea8862cc9c > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java > ed8e8119ac3dc41c18316a1ca6e34c178916b09d > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java > 3f045ff38d672266ce2e2bb26f729b0ca4657e81 > > Diff: https://reviews.apache.org/r/38014/diff/ > > > Testing > ------- > > test suite > ./gradlew run > end-to-end tests > > > Thanks, > > Bill Farner > >
