----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98084 -----------------------------------------------------------
src/main/resources/scheduler/assets/js/controllers.js (line 183) <https://reviews.apache.org/r/38169/#comment154325> Since the max length of 6 assumes a column can fit into 2 bootstrap columns, the logic can just be col-md-{columns.length * 2} here. src/main/resources/scheduler/assets/js/controllers.js (line 206) <https://reviews.apache.org/r/38169/#comment154328> Style nit, but declare the function before you call it. - David McLaughlin On Sept. 8, 2015, 9:10 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38169/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 9:10 p.m.) > > > Review request for Aurora, David McLaughlin and Joshua Cohen. > > > Bugs: AURORA-1461 > https://issues.apache.org/jira/browse/AURORA-1461 > > > Repository: aurora > > > Description > ------- > > Making Resources table dynamic to display only non-zero resource vectors (see > pics attached). Table width is now dependent on the number of visible > columns. > > Not particularly happy about ng-class approach to control table width, so any > suggestions how to make it better are welcome. > > May not apply cleanly, diffed against 38081. > > > Diffs > ----- > > src/main/resources/scheduler/assets/js/controllers.js > 98920196db34f2eb4dcad93429274517e7383efe > src/main/resources/scheduler/assets/role.html > 2572c4b4497aa78d3fa31457a5dc7c57e6565027 > > Diff: https://reviews.apache.org/r/38169/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > resources_full.png > > https://reviews.apache.org/media/uploaded/files/2015/09/08/ada720ce-bb97-4321-99bb-0574bf14b653__resources_full.png > resources_partial.png > > https://reviews.apache.org/media/uploaded/files/2015/09/08/a6e4aa7e-ca7e-4ca4-900e-fda6cfdcaff3__resources_partial.png > resources_min.png > > https://reviews.apache.org/media/uploaded/files/2015/09/08/c44964f2-d8d7-41b0-8a4f-995a1e3538f1__resources_min.png > > > Thanks, > > Maxim Khutornenko > >
