----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98509 -----------------------------------------------------------
This patch does not apply cleanly on master (98f692d), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 10, 2015, 11:56 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38270/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 11:56 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1474 and AURORA-783 > https://issues.apache.org/jira/browse/AURORA-1474 > https://issues.apache.org/jira/browse/AURORA-783 > > > Repository: aurora > > > Description > ------- > > Remove redundancy between breadcrumbs and page headers. Also make job > dashboard link more prominent. > > > Diffs > ----- > > examples/vagrant/upstart/aurora-scheduler.conf > f710295349c081ec9440bf5668a6e075a863b6c1 > src/main/resources/scheduler/assets/breadcrumb.html > 9265277b4a9347db28aaa9c367f259af4876d8ac > src/main/resources/scheduler/assets/css/app.css > faa387b98a12ea6dcdb8d19b91af95b07302eda9 > src/main/resources/scheduler/assets/home.html > fadf00d81b8f9b62597cca24396b27c42fb9c89b > src/main/resources/scheduler/assets/instance.html > 317e2ce3f236ec58d57289217034c79ac543a3fe > src/main/resources/scheduler/assets/job.html > a8be604b27620e2bb3fca1254de9dc66f6bae111 > src/main/resources/scheduler/assets/js/controllers.js > 4acab107e1a4ecf310192c9bb3ad2a3f90f524f1 > src/main/resources/scheduler/assets/js/services.js > dbad59b79a4b08d8b022419eeb89053f6c36d1ea > src/main/resources/scheduler/assets/role.html > 2572c4b4497aa78d3fa31457a5dc7c57e6565027 > > Diff: https://reviews.apache.org/r/38270/diff/ > > > Testing > ------- > > ./gradlew jsHint > > See attached screenshots. > > > File Attachments > ---------------- > > Home Page > > https://reviews.apache.org/media/uploaded/files/2015/09/10/7ab3b0a2-82e5-4451-9d22-e3c2ee9c9674__Screen_Shot_2015-09-10_at_6.47.50_PM.png > Role Page > > https://reviews.apache.org/media/uploaded/files/2015/09/10/0b1035d9-8156-4889-a136-1b9fc5794ff7__Screen_Shot_2015-09-10_at_6.47.54_PM.png > Job Page > > https://reviews.apache.org/media/uploaded/files/2015/09/10/9c717720-0480-4fbb-9b44-ca027b1f1232__Screen_Shot_2015-09-10_at_6.47.57_PM.png > Instance Page > > https://reviews.apache.org/media/uploaded/files/2015/09/10/1ee53992-9347-4ced-8707-055880bee5b5__Screen_Shot_2015-09-10_at_6.48.03_PM.png > Update Page > > https://reviews.apache.org/media/uploaded/files/2015/09/10/9f85e4eb-28e9-4507-a217-6bd20953b1b8__Screen_Shot_2015-09-10_at_6.48.08_PM.png > Environment Page > > https://reviews.apache.org/media/uploaded/files/2015/09/10/85b7311d-2ad9-4769-8b49-9e1410d817fc__Screen_Shot_2015-09-10_at_6.50.53_PM.png > > > Thanks, > > Joshua Cohen > >
