----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39073/#review102069 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/__init__.py (line 172) <https://reviews.apache.org/r/39073/#comment159595> Mind renaming ConfigurationPlugin occurrences in test to make sure we have coverage for both names? src/main/python/apache/aurora/client/cli/__init__.py (line 255) <https://reviews.apache.org/r/39073/#comment159593> Any chance you could add test coverage here? - Maxim Khutornenko On Oct. 7, 2015, 5:29 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39073/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 5:29 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Generalize plugin interface for client. > > 1. Renames ConfigurationPlugin to just Plugin, since you can register nouns; > aliases the two together > 2. Adds get_nouns method that allows you to register new top-level commands > 3. Searches entry_points for plugins registered under > apache.aurora.client.cli.plugin > > I have used this to implement a proof-of-concept 'aurora deploy' staged > rollout framework as well as basic S3 integration (will publish to > github.com/wickman/sacker separately.) > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > c1c54549fd8718275041b54e1e91b070dadc05da > > Diff: https://reviews.apache.org/r/39073/diff/ > > > Testing > ------- > > Used it to create a sacker plugin for aurora client. > > > Thanks, > > Brian Wickman > >
