----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/#review103675 -----------------------------------------------------------
Ship it! I'm fine with this patch as-is. No great reason to keep a feature that hasn't had good follow-through. It's in the way, let's knock it down. I agree that the thrift fields should be removed, but would prefer to see that in a follow-up ticket. - Bill Farner On Oct. 22, 2015, 2:35 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39563/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 2:35 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1522 > https://issues.apache.org/jira/browse/AURORA-1522 > > > Repository: aurora > > > Description > ------- > > Ignore serverInfo on the client side. > > The design of this check is flawed - the client has already sent an RPC to > the scheduler and received a response for it, meaning the request has already > been processed and this check only serves to ignore its results. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > 8e91788d8cb69ef21df6b045cd07f8cb111b95b3 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3 > > Diff: https://reviews.apache.org/r/39563/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Sweeney > >
