----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40208/#review106297 -----------------------------------------------------------
Ship it! Ship It! - Zameer Manji On Nov. 11, 2015, 3:58 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40208/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2015, 3:58 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-954 > https://issues.apache.org/jira/browse/AURORA-954 > > > Repository: aurora > > > Description > ------- > > Under older pants, and thus older pex, distributions were fetched using > urllib and were not robust to flaky connections. Now that Aurora is on > modern pants and pex, which uses the `requests` library for fetching and > includes 5 retries by default, this step should no longer be needed to > ensure stable CI runs. > > build-support/jenkins/build.sh | 7 ------- > pants.ini | 5 ----- > 2 files changed, 12 deletions(-) > > > Diffs > ----- > > build-support/jenkins/build.sh 5cd5242a2e4551e356e5ce5d15a0d27beb7e2d4e > pants.ini 0bd8ec829ae65e2296a122166dea13f315323c9f > > Diff: https://reviews.apache.org/r/40208/diff/ > > > Testing > ------- > > I still can't quite run `./build-support/jenkins/build.sh` straight up > due to https://issues.apache.org/jira/browse/AURORA-1083 but ran the > following successfully locally which forces re-download of requirements > by pants: > ``` > $ ./pants clean-all test.pytest --no-fast src/test/python:: > ``` > > > Thanks, > > John Sirois > >