----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review109857 -----------------------------------------------------------
Master (6933a71) is red with this patch. ./build-support/jenkins/build.sh virtualenv-12.1.1/virtualenv_embedded/activate.sh virtualenv-12.1.1/virtualenv_embedded/activate_this.py virtualenv-12.1.1/virtualenv_embedded/deactivate.bat virtualenv-12.1.1/virtualenv_embedded/distutils-init.py virtualenv-12.1.1/virtualenv_embedded/distutils.cfg virtualenv-12.1.1/virtualenv_embedded/site.py virtualenv-12.1.1/virtualenv_support/ virtualenv-12.1.1/virtualenv_support/__init__.py virtualenv-12.1.1/virtualenv_support/pip-6.1.1-py2.py3-none-any.whl virtualenv-12.1.1/virtualenv_support/setuptools-15.0-py2.py3-none-any.whl + touch virtualenv-12.1.1/BOOTSTRAPPED + popd ~/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-12.1.1/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip...done. /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning You are using pip version 6.1.1, however version 7.1.2 is available. You should consider upgrading via the 'pip install --upgrade pip' command. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Using cached isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py:before 2015-12-10 21:22:19.640553 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py:after 2015-12-10 21:27:31.758846 @@ -22,8 +22,8 @@ from twitter.common.exceptions import ExceptionalThread from twitter.common.metrics import LambdaGauge +from apache.aurora.common.health_check.http_signaler import HttpSignaler from apache.aurora.common.health_check.shell import ShellHealthCheck -from apache.aurora.common.health_check.http_signaler import HttpSignaler from .status_checker import StatusChecker, StatusCheckerProvider, StatusResult from .task_info import mesos_task_instance_from_assigned_task, resolve_ports I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 10, 2015, 9:16 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41154/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 9:16 p.m.) > > > Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1551 > https://issues.apache.org/jira/browse/AURORA-1551 > > > Repository: aurora > > > Description > ------- > > Adding support for non-HTTP health checks. > > > Diffs > ----- > > 3rdparty/python/requirements.txt cfef18ee66b0f92d83c53dacb6d9376fc2e50445 > docs/configuration-reference.md 364292998bebb233d300fe59c9ea42b216deee81 > src/main/python/apache/aurora/common/BUILD > 5fce3d0d29d2a38c6563b4d9be963532e595ee19 > src/main/python/apache/aurora/common/health_check/BUILD PRE-CREATION > src/main/python/apache/aurora/common/health_check/__init__.py PRE-CREATION > src/main/python/apache/aurora/common/health_check/shell.py PRE-CREATION > src/main/python/apache/aurora/common/http_signaler.py > a3193f3259276ec23d37f45839afe3c387cff6b1 > src/main/python/apache/aurora/config/schema/base.py > 398f737bed9ef02ce4a5636896d6587bce26501e > src/main/python/apache/aurora/executor/common/health_checker.py > 03fdf0afef120c365c6ffad09e152780eed7e351 > src/main/python/apache/aurora/executor/http_lifecycle.py > 6d578cceb56375425ccac1cbfbbcd0add60f20e9 > src/test/python/apache/aurora/common/BUILD > 2556c32842b3cf7040cb3c41172a0d9c365cb649 > src/test/python/apache/aurora/common/health_check/BUILD PRE-CREATION > src/test/python/apache/aurora/common/health_check/__init__.py PRE-CREATION > src/test/python/apache/aurora/common/health_check/test_shell.py > PRE-CREATION > src/test/python/apache/aurora/common/test_http_signaler.py > f68c71a6765f7f0b93c8c50662515b5742344f35 > src/test/python/apache/aurora/executor/common/test_health_checker.py > 27c71711d52f757ed1552db4accda671a6bdafdd > > Diff: https://reviews.apache.org/r/41154/diff/ > > > Testing > ------- > > Added unit tests. > Ran e2e test. > Tested expected behavior on virtual Mesos cluster. > > > Thanks, > > Dmitriy Shirchenko > >
