> On Dec. 15, 2015, 11:46 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/HttpStatsFilter.java, line 57 > > <https://reviews.apache.org/r/41392/diff/3/?file=1164532#file1164532line57> > > > > Drive by post-commit comment. Can we not supress deprecation without a > > comment explaining what it is supressing?
In this case, that sounds highly redundant. We are implementing an interface that contains a deprecated method, and forwarding to the wrapped instance thus calling its deprecated method. This results in a compiler warning. I generally agree with annotating suppressions, but not in this case. > On Dec. 15, 2015, 11:46 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line > > 395 > > <https://reviews.apache.org/r/41392/diff/3/?file=1164533#file1164533line395> > > > > The addition of Slf4J here further complicates our logging story. Plus, > > I'm not aware of us bundling any slf4j backends with our build so I am > > pretty sure these request messages are now lost. > > > > Bill, can you confirm/deny these messages are kept and if so, what is > > is the slf4j backend that is used? Not sure what you mean. We already rely on slf4j slf4j-jdk14. I was able to quickly verify via `./gradlew run` that logging works: ``` I1215 20:32:46.734 THREAD137 org.eclipse.jetty.server.Slf4jRequestLog.write: 0:0:0:0:0:0:0:1 - - [15/Dec/2015:20:32:46 +0000] "GET //localhost:8081/assets/index.html HTTP/1.1" 200 568 ``` - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/#review110552 ----------------------------------------------------------- On Dec. 14, 2015, 10:39 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41392/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 10:39 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Jetty 7 and 8 are are at EOL and in maintenace mode. This brings us up to > the latest. > > > Diffs > ----- > > build.gradle ab1ec1ccebc3366db9531d6518507c7e7a5a6e64 > src/main/java/org/apache/aurora/scheduler/http/HttpStatsFilter.java > 7ffd10573b31089c850802854b344433d64ed08b > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > c78315da4b7a23fac274e10e2c8bcb4001a0d94c > src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java > ef6a84879a2a90d2c7ff2a81a723b20c56d550c2 > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > 791fd45646f4b353122e723b43b22b44baf5279b > src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java > a2f786a588633e82890c2e8d695a5be2fde45452 > src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java > 3a18e94e3459b020f86a4f50e4f7e745ed33e670 > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh > 82ff8682d9b22236f3488cd7c107e2bba87c1e23 > > Diff: https://reviews.apache.org/r/41392/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
