----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review112928 -----------------------------------------------------------
Ship it! Is it possible to get thread id instead of thread name by default? I think that is more valuable when debugging issues and will reudce the size of each log line. - Zameer Manji On Jan. 3, 2016, 9:04 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41785/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2016, 9:04 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Using log4j as a straw man. If we decide to choose logback instead, i'm > happy to update this patch. > > Here's an example of the log format: > ``` > I1229 22:16:54.568 [pool-10-thread-1, FakeMaster:139] All offers consumed, > suppressing offer cycle. > ``` > As opposed to what's on master: > ``` > I1230 06:26:14.987 THREAD143 > org.apache.aurora.scheduler.app.local.FakeMaster.lambda$start$0: All offers > consumed, suppressing offer cycle. > ``` > > I could more closely match the existing format, but i think the change is an > improvement. > > TODO before submitting: Update `LogConfig` to align with the selected > backend. I'll wait until we decide on a backend before i update this. > > > Diffs > ----- > > NEWS c0c454d080023a2e2796022f957a4d47bdb87b41 > build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75 > commons/src/main/java/org/apache/aurora/common/logging/Glog.java > 5bae399cd9360a0093c67c608cf68b013a709194 > commons/src/main/java/org/apache/aurora/common/logging/LogFormatter.java > 0cb621da2b2f286d9eda9eb18ecac087208d7b6b > commons/src/main/java/org/apache/aurora/common/logging/RootLogConfig.java > 26dd0aa5682faf31ba4cc086d32bf61557ef1fde > > commons/src/main/java/org/apache/aurora/common/logging/log4j/GlogLayout.java > 1a90ded72c81a7e3fdc9dab515a2622c55563e6a > > commons/src/test/java/org/apache/aurora/common/logging/LogFormatterTest.java > 9f041915c7fd4513a6255b05b3d0096779b5f1b3 > > commons/src/test/java/org/apache/aurora/common/logging/RootLogConfigTest.java > 9d55a1aaf555d6e25ad97622612fad61271d0e25 > examples/vagrant/upstart/aurora-scheduler-kerberos.conf > 4f43892723db4744db205ea7dd107e9e9ce9d5db > examples/vagrant/upstart/aurora-scheduler.conf > 4033184451f36cb5f0233ea96e3dceaae6741275 > src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java > 348ff1345a3d5ff4212a2cb211e973ad9e2ca2e8 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > de018dd3cd82b7a0a1cb285f8f3172dae529817f > src/main/resources/log4j2.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/41785/diff/ > > > Testing > ------- > > end-to-end tests are green > > > Thanks, > > Bill Farner > >
