----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review113633 -----------------------------------------------------------
Any chance of getting this merged? It might be a surprise to some users, since right now there's no requirement for matching role accounts to exist inside the docker images, but with the right documentation about how to retain the "always root in the container" behavior it ought to be ok. - Benjamin Staffin On Nov. 2, 2015, 10:26 a.m., Bhuvan Arumugam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2015, 10:26 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > ------- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > ----- > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > ------- > > > Thanks, > > Bhuvan Arumugam > >