-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41785/#review113934
-----------------------------------------------------------


Master (6a5309a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 12, 2016, 4:55 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41785/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 4:55 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Here's an example of the log format:
> ```
> I1229 22:16:54.568 [pool-10-thread-1, FakeMaster:139] All offers consumed, 
> suppressing offer cycle.
> ```
> As opposed to what's on master:
> ```
> I1230 06:26:14.987 THREAD143 
> org.apache.aurora.scheduler.app.local.FakeMaster.lambda$start$0: All offers 
> consumed, suppressing offer cycle.
> ```
> 
> I could more closely match the existing format, but i think the change is an 
> improvement.
> 
> 
> Diffs
> -----
> 
>   NEWS ecb26d2af2c624042e7819acde004278520b3cae 
>   build.gradle 8e7ea3790d6a5d378cbd90021a9717d50874fdb9 
>   commons/src/main/java/org/apache/aurora/common/logging/Glog.java 
> 5bae399cd9360a0093c67c608cf68b013a709194 
>   commons/src/main/java/org/apache/aurora/common/logging/LogFormatter.java 
> 0cb621da2b2f286d9eda9eb18ecac087208d7b6b 
>   commons/src/main/java/org/apache/aurora/common/logging/RootLogConfig.java 
> 26dd0aa5682faf31ba4cc086d32bf61557ef1fde 
>   
> commons/src/main/java/org/apache/aurora/common/logging/log4j/GlogLayout.java 
> 1a90ded72c81a7e3fdc9dab515a2622c55563e6a 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  d3c6dddf86ac3dc0b36b851e16c8ada9a896b8f0 
>   
> commons/src/main/resources/org/apache/aurora/common/net/http/handlers/logconfig.st
>   
>   
> commons/src/test/java/org/apache/aurora/common/logging/LogFormatterTest.java 
> 9f041915c7fd4513a6255b05b3d0096779b5f1b3 
>   
> commons/src/test/java/org/apache/aurora/common/logging/RootLogConfigTest.java 
> 9d55a1aaf555d6e25ad97622612fad61271d0e25 
>   config/legacy_untested_classes.txt f183518122b7815e64d55b58b5a6de56ec7d0ef4 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 4f43892723db4744db205ea7dd107e9e9ce9d5db 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 4033184451f36cb5f0233ea96e3dceaae6741275 
>   src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java 
> 348ff1345a3d5ff4212a2cb211e973ad9e2ca2e8 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> de018dd3cd82b7a0a1cb285f8f3172dae529817f 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 6c5654ba33783f81b8da7b6500bf4fc8f101e7e3 
>   src/main/resources/logback.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41785/diff/
> 
> 
> Testing
> -------
> 
> end-to-end tests are green
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to