----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114724 -----------------------------------------------------------
Ship it! NEWS (line 26) <https://reviews.apache.org/r/42328/#comment175584> It this really news-worthy? I'd expect it to be a low noise feature related summary. IMO, adding a stat does not clear that bar. - Maxim Khutornenko On Jan. 14, 2016, 11:58 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42328/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 11:58 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Bugs: AURORA-1582 > https://issues.apache.org/jira/browse/AURORA-1582 > > > Repository: aurora > > > Description > ------- > > Add metric "async_executor_uncaught_exceptions" for tracking uncaught > exceptions in async executor. > > > Diffs > ----- > > NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java > 5facc048bc21adb124cb761647553afa9f8ab724 > > Diff: https://reviews.apache.org/r/42328/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >