> On Jan. 15, 2016, 9:57 a.m., Maxim Khutornenko wrote: > > History prunner is regsistered as a service. Shouldn't its failure triger a > > shutdown according to this: https://reviews.apache.org/r/39631?
`TaskHistoryPruner` is not a service, only `JobUpdateHistoryPruner` is. Even if this was a service this error would not shut it down because the exception occurs on a separate thread. In this case the exception occurs on the executor threads provided by `AsyncModule`. Previously, a failure there would just be logged (and I recently added support for a metric). I talked with John about this and we agreed that clients of this executor should be responsible for determining if an exception in the Runnable is fatal or not. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114732 ----------------------------------------------------------- On Jan. 14, 2016, 4:53 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42332/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 4:53 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Bugs: AURORA-1582 > https://issues.apache.org/jira/browse/AURORA-1582 > > > Repository: aurora > > > Description > ------- > > Task pruning is critical to the operation of a large cluster. Failure to > prune tasks can lead to storage growing in unexpected ways leading to > scheduling slowdown. This patch adds shutdown on task pruning failure to > prevent the scheduler from entering an undefined state. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > 2064089937f5178b1413d386a312f4173a0e35fb > > src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java > 295960f13693c6ba0d7075a8ef7f9680a91ae69d > > Diff: https://reviews.apache.org/r/42332/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Zameer Manji > >
