----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/ -----------------------------------------------------------
(Updated Jan. 20, 2016, 11:47 a.m.) Review request for Aurora, John Sirois and Zameer Manji. Changes ------- Removed some deltas to simplify the patch and highlight relevant changes. Repository: aurora Description ------- This patch proposes that users installing custom modules do so via a custom main. Specifying custom modules on the command line has proven troublesome for replacing the command line args system with one where all arguments are injected and explicitly-defined. It also adds complexity to the scheduler application by unnecessarily punching holes at specific places. If this proposal is agreeable, i will add a NEWS entry and document how one might implement a custom main to add modules. The tl;dr, however, is to invoke `SchedulerMain.publicMain(customModule)` Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/app/MoreModules.java d5f96543d1068bf30b9d173a247c2806faf35578 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 0659c358479283756179c2cabebc8416730cc3e3 src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2 src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java ccd9a20e8b18831458cba2d53e6b8b84fef06162 src/test/java/org/apache/aurora/scheduler/app/MoreModulesTest.java b2fb3c9dcba64f69a05894f506ba43766f74ddaa src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3 src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java baaeb2390a909de1a92e4328d35a49f7b74c36cb Diff: https://reviews.apache.org/r/42565/diff/ Testing ------- end-to-end tests, `./gradlew run` Thanks, Bill Farner
