----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/ -----------------------------------------------------------
(Updated Jan. 21, 2016, 3:43 p.m.) Review request for Aurora, John Sirois and Maxim Khutornenko. Changes ------- Maxim's feedback. Bugs: AURORA-1582 https://issues.apache.org/jira/browse/AURORA-1582 Repository: aurora Description ------- Task pruning is key to operating a large cluster and failure to prune should trigger shutdown to prevent unbounded growth of storage. This patch turns `TaskHistoryPruner` into a service which propagates failure from failed pruning attempts towards the `ServiceManager`. Also completing a TODO which removes a test for behaviour that is very awkward to test for. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 735199ac1ccccab343c24471890aa330d6635c26 src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 2064089937f5178b1413d386a312f4173a0e35fb src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java 295960f13693c6ba0d7075a8ef7f9680a91ae69d Diff: https://reviews.apache.org/r/42332/diff/ Testing ------- ./gradlew build -Pq e2e tests Thanks, Zameer Manji