----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115930 -----------------------------------------------------------
Fix it, then Ship it! src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 441) <https://reviews.apache.org/r/42666/#comment176975> Following up from earlier comment - `active()` scoping is absent here, which can result in log noise as illegal task transitions are attempted. Consider pulling the `implicitKillQuery` call out so that it covers all branches. - Bill Farner On Jan. 22, 2016, 1:13 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42666/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 1:13 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1583 > https://issues.apache.org/jira/browse/AURORA-1583 > > > Repository: aurora > > > Description > ------- > > Following the path consistent with restartShards using JobKey + instanceIds. > > > Diffs > ----- > > NEWS 37a7a7933b20e112416b01260d97fc2f47c24027 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > f099620967a7836538f19545fe373faa335529a4 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 69eab90fa053c917a6a2c60b548802ba450fa80c > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java > f6669efe9d00ead3f123dda6f6152ae273e1a6c4 > src/main/python/apache/aurora/client/api/__init__.py > ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6 > > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java > 3e811a4f4d2c82892217ca1f950ac792303fbcf3 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java > 79e70fde1633e6dfbed2171cceee0197acae2550 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > d12b56eb675e5187fb375a27ace3849fdab1dd8d > > src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java > 065ad425a0d359c3d73db197b528ab45bf9f6bda > src/test/python/apache/aurora/api_util.py > 5b2a5383ffa490dcf651c027074ed42bba0ab644 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8 > > Diff: https://reviews.apache.org/r/42666/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Maxim Khutornenko > >