> On Jan. 29, 2016, 3:32 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 87
> > <https://reviews.apache.org/r/42985/diff/1/?file=1226118#file1226118line87>
> >
> >     I suggest you raise the default to a very conservative level (like 1 
> > minute) until we better understand how the newly-introduced locking affects 
> > the app.  A high timeout means potentially waiting longer, but avoids 
> > issues where parts of the app because we don't handle a lock timeout.

Done.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117049
-----------------------------------------------------------


On Feb. 1, 2016, 2:44 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42985/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 2:44 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1596
>     https://issues.apache.org/jira/browse/AURORA-1596
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a flag to configure H2 LOCK_TIMEOUT.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> a0344f7f6bf2b468820a2279a36bd6c945d760c0 
> 
> Diff: https://reviews.apache.org/r/42985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to