----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122678 -----------------------------------------------------------
Master (bab21ed) is red with this patch. ./build-support/jenkins/build.sh virtualenv-14.0.6/virtualenv_embedded/activate.ps1 virtualenv-14.0.6/virtualenv_embedded/activate.sh virtualenv-14.0.6/virtualenv_embedded/activate_this.py virtualenv-14.0.6/virtualenv_embedded/deactivate.bat virtualenv-14.0.6/virtualenv_embedded/distutils-init.py virtualenv-14.0.6/virtualenv_embedded/distutils.cfg virtualenv-14.0.6/virtualenv_embedded/python-config virtualenv-14.0.6/virtualenv_embedded/site.py virtualenv-14.0.6/virtualenv_support/ virtualenv-14.0.6/virtualenv_support/__init__.py virtualenv-14.0.6/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/setuptools-20.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-14.0.6/BOOTSTRAPPED + popd ~/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-14.0.6/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:315: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning. SNIMissingWarning /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:120: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Using cached isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py:before 2016-03-09 05:21:26.749548 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py:after 2016-03-09 05:32:48.681704 @@ -19,7 +19,6 @@ from mesos.interface.mesos_pb2 import TaskState from pystachio import Environment, String - from twitter.common import log from twitter.common.exceptions import ExceptionalThread from twitter.common.metrics import LambdaGauge I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 9, 2016, 5:11 a.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 5:11 a.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1622 > https://issues.apache.org/jira/browse/AURORA-1622 > > > Repository: aurora > > > Description > ------- > > Exposing DSL defined variables to shell health checkers > > > Diffs > ----- > > src/main/python/apache/aurora/common/health_check/shell.py > 890bf0c5d50d0022c044a37191a2e3145cc6340f > src/main/python/apache/aurora/executor/common/health_checker.py > 303972778baa04e9d7dd47fb208fe1427e779976 > src/test/python/apache/aurora/common/health_check/test_shell.py > 84f717fbf724c11863b4980fd2740dc23fe1404e > src/test/python/apache/aurora/executor/common/test_health_checker.py > 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 > > Diff: https://reviews.apache.org/r/44486/diff/ > > > Testing > ------- > > Unit and end to end test. > > > Thanks, > > Dmitriy Shirchenko > >