> On March 10, 2016, 10:04 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95 > > <https://reviews.apache.org/r/44532/diff/1/?file=1292348#file1292348line95> > > > > Specifying the command here feels kind of weird. All other options we > > have take the value directly.
Executor arguments are set in stone after starting the scheduler as they are passed to the scheduler through -thermos_executor_flags, so we have to do it this way. - Kunal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123011 ----------------------------------------------------------- On March 8, 2016, 10:33 p.m., Kunal Thakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44532/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 10:33 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Allow overriding hostname before announcing > > > Diffs > ----- > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > f82858c528808d2a9e77bb56f16e897cfb5bbe73 > src/main/python/apache/aurora/executor/common/announcer.py > 34e36e0a59093468a8934f58bacb68512949347c > > Diff: https://reviews.apache.org/r/44532/diff/ > > > Testing > ------- > > > Thanks, > > Kunal Thakar > >
