----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123044 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 180) <https://reviews.apache.org/r/44685/#comment185173> Changes from here down are mostly applying LoD, but also refactoring `configureTaskForDockerContainer()` so i could use it to extract a `ContainerInfo` - Bill Farner On March 10, 2016, 4:37 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44685/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 4:37 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This is currently labeled as experimental. > > Only the most basic wiring is added here, and assumes that the provided image > includes an ENTRYPOINT. Unlike Docker support via the thermos executor, this > approach allows containers with an entrypoint, and does not impose environment > requirements on the image (e.g. python interpreter, libmesos dependencies). > > Note that when using this, other familiar Aurora facilities that relate to the > thermos executor will not work. For example, browsing task logs is not > supported. > > Support for exercising this from the client will come shortly. > > > Diffs > ----- > > NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > 60746383fccb107ca27925a91aa1803e2cf0fd85 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > a0d2a717534bbb2e85a556721cc53c1e4b743461 > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 1de6966565d2fbd9abd220ad8162b624b109959a > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 6300e5f83b039a9798e7093f6b46c84566e507e0 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > a34af4d2fb3863ab8197bcdce942c513d629621b > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > d2789d0eaaeba99fcff3412f1abdd29a09d6514d > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > 3db531b52fb2bd94b4b5ce62e6554b5a85ed3ea8 > > Diff: https://reviews.apache.org/r/44685/diff/ > > > Testing > ------- > > Via additional hacking, i successfully ran the stock [hello > world](https://hub.docker.com/_/hello-world/) image. Within the sandbox, i > observed the expected output in the `stdout` file. Status updates for the > task exiting worked as expected. > > > Thanks, > > Bill Farner > >