> On April 7, 2016, 5:42 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java, > > line 108 > > <https://reviews.apache.org/r/45902/diff/2/?file=1331375#file1331375line108> > > > > Shouldn't this be fatal? To me to looks like this exception can only > > throw if there is a ZK problem `data.getData()` is null, or the data is > > malformed (bug in a follower). > > John Sirois wrote: > That's certainly how the commons impl treats it - it throws a > RuntimeException. I clearly re-thought that, though did not add a stat. It > seemed to me on re-examination that malformed data is not conceptually > different from a non-member node name collision. In that case I'd think the > right answer would be to proceed and log (and possibly alert); ie: a > ~malicious actor made a "member_000000X" node - this presumably shouldn't > stop the scheduler. > > LMK what you think.
Your reasoning is solid, I'll drop this issue. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127708 ----------------------------------------------------------- On April 7, 2016, 4:07 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45902/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 4:07 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1468 > https://issues.apache.org/jira/browse/AURORA-1468 > > > Repository: aurora > > > Description > ------- > > build.gradle > | 5 ++ > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java > | 94 +++++++++++++++++++++++ > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java > | 205 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 304 insertions(+) > > > Diffs > ----- > > build.gradle ad5ec5c4afe4dd5c2189d0680692a7409f0417a9 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45902/diff/ > > > Testing > ------- > > Locally green: `./gradlew -Pq build`. > > > Thanks, > > John Sirois > >