> On April 12, 2016, 1:39 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 31 > > <https://reviews.apache.org/r/46064/diff/1/?file=1340123#file1340123line31> > > > > It's probably time for some constants to justify these constants (or at > > least admit that they are lies!).
Not sure I follow, these _are_ the constants baked into the enum with the intention to hide all definitions inside this class and anonymize values via getters. Exposing global constants here will defeat the purpose of this change. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46064/#review128315 ----------------------------------------------------------- On April 12, 2016, 12:03 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46064/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 12:03 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > First step towards consolidating resource definitions: getting rid of custom > ResourceVector enum. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > f8c57f9ba7c8d07c14c7a27738e2fba023a2cf03 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > fc9b10b6ecc8bbc3111e516f7a882456f5bc7bd3 > > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java > 1d9d5fc98494892b7d90e97f93db267d42ba7619 > > Diff: https://reviews.apache.org/r/46064/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
