> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > <https://reviews.apache.org/r/46803/diff/1/?file=1365181#file1365181line139> > > > > I am not too keen on having a column for an optional field that will > > most likely read 'default' for all jobs. Perhaps postpone its introduction > > until TaskConfig.tier is required? > > Amol Deshmukh wrote: > I thought that leaving it blank would raise more questions for most users > who did not use tiers at all (basically the same point that Joshua raised > above). > > I'll leave it blank and we can address that if the need arises. > > Joshua Cohen wrote: > I'd be ok with just not shipping this change until TaskConfig.tier is > required and users are actually aware of it.
I thought we had concluded that tier would not become a required field in user configurations? - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131028 ----------------------------------------------------------- On April 28, 2016, 7:54 p.m., Amol Deshmukh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46803/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 7:54 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > AURORA-1458: Add tier into the UI "show config" summary. > > > Diffs > ----- > > src/main/resources/scheduler/assets/configSummary.html > 1af7511de0e8a143c8ea88377aad756b44e3ac30 > src/main/resources/scheduler/assets/js/controllers.js > 84417ebeadfae57d55b9f12e8a985825bd620fc8 > src/main/resources/scheduler/assets/js/services.js > d9ce52065f9573b0aa68a95da7da7c50fb14310a > src/main/resources/scheduler/assets/schedulingDetail.html > eb88c1e6dec7a26643e8b13ffcf8e90df70a67f7 > > Diff: https://reviews.apache.org/r/46803/diff/ > > > Testing > ------- > > Ensured the changes appear in the UI after launching the scheduler using > vagrant. > > > File Attachments > ---------------- > > Jobs by Role > > https://reviews.apache.org/media/uploaded/files/2016/04/29/6e58d26d-e77c-49fe-85e0-ee1acae3efe0__Jobs_by_Role.png > Per Job Config Summary > > https://reviews.apache.org/media/uploaded/files/2016/04/29/8a666fe7-9a35-427f-b1ee-f41e5413059d__Per_Job_Config_Summary.png > > > Thanks, > > Amol Deshmukh > >
