----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review133809 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/update.py (lines 162 - 182) <https://reviews.apache.org/r/47550/#comment198439> Please, move this into something like `diff_formatter.py` and share between `jobs.py` and `update.py`. We shouldn't duplicate this functionality. src/main/python/apache/aurora/client/cli/update.py (line 220) <https://reviews.apache.org/r/47550/#comment198441> I suggest moving this call before the `start_job_update()` to give an expected change preview right before the update call is placed. - Maxim Khutornenko On May 18, 2016, 8:55 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47550/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 8:55 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > AURORA-1492 Improve "aurora update start" command output > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/update.py > eb7e9b0799bb25af652a0d5bde231cfca5bc1510 > src/test/python/apache/aurora/client/cli/test_supdate.py > 2135ca988ce2f260262145a2168849acd8d14874 > > Diff: https://reviews.apache.org/r/47550/diff/ > > > Testing > ------- > > Automated: ./pants test.pytest --no-fast src/test/python:: > Manual: using vagrant > e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > Style: ./build-support/hooks/pre-commit > > Example output: > > aurora update start devcluster/www-data/prod/hello > ./aurora/examples/jobs/updated_hello_world.aurora > INFO] Starting update for: hello > Job update has started. View your update progress at > http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b > This job update will: > add instances: [2-3] > update instances: [0-1] > > > Thanks, > > Mehrdad Nurolahzade > >
