Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139819
-----------------------------------------------------------



Master (73dd2a8) is red with this patch.
  ./build-support/jenkins/build.sh

                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_empty 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables
 PASSED
                     
                     ==================== FAILURES ====================
                      test_get_config_with_production_and_tier_is_preemptible 
                     
                         def 
test_get_config_with_production_and_tier_is_preemptible():
                           context = FakeAuroraCommandContext()
                           context.set_options(create_mock_options())
                           with 
CLUSTERS.patch(AuroraClientCommandTest.TEST_CLUSTERS.values()):
                             api = context.get_api(TEST_CLUSTER.name)
                             api.get_tier_configs.return_value = 
AuroraClientCommandTest.get_mock_tier_configurations()
                             with temporary_file() as fp:
                               fp.write(create_test_config())
                               fp.flush()
                               config = 
context.get_job_config(AuroraClientCommandTest.TEST_JOBKEY, fp.name)
                               assert not 
config.job().taskConfig.production
                     >         assert config.job().taskConfig.tier == 
AuroraClientCommandTest.PREEMPTIBLE_TIER.name
                     E         assert 'revocable' == 'preemptible'
                     E           - revocable
                     E           + preemptible
                     
                     
src/test/python/apache/aurora/client/cli/test_context.py:110: AssertionError
                     -------------- Captured stderr call --------------
                     INFO:root:OK
                      INFO] OK
                      INFO] OK
                      INFO] OK
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      1 failed, 667 passed, 6 skipped, 1 warnings in 
198.50 seconds 
                     
FAILURE


               Waiting for background workers to finish.
17:01:40 04:08   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2016, 4:51 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 4:51 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - CLI changes
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 68baf8fdb90cd26100159401c46c9963c24332b3 
>   src/main/python/apache/aurora/client/base.py 
> 73953b69b247cf86e691310423b63b3a40f95976 
>   src/main/python/apache/aurora/client/cli/context.py 
> 9b1511801d031ff48b81c25688a55cb586b8ac66 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 2130f1fa71be02a004cdf8e476a270c81a7105d3 
>   src/test/python/apache/aurora/client/cli/test_context.py 
> 204ca092adad8bf43c5032a02f61bf303fb0b2fc 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f3c522ed94a2d774865811ceb546bf9df083c14f 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> a545fece5e2b3e0017a61e1be9ac478372b1f34d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 967d560e5c7eb0ed85b215fb11d9751b8666acb5 
>   src/test/python/apache/aurora/client/cli/util.py 
> 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/client/test_config.py 
> b1a3c1865819899ef19173be0f861783a2631d0a 
> 
> Diff: https://reviews.apache.org/r/49048/diff/
> 
> 
> Testing
> -------
> 
> ```
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> *** OK (All tests passed) ***
> 
> mesos-master start/running, process 26868
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  19m46.324s
> user  0m1.496s
> sys   0m0.774s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>