----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49512/#review140365 -----------------------------------------------------------
Master (b3f88bc) is red with this patch. ./build-support/jenkins/build.sh virtualenv-14.0.6/virtualenv_embedded/distutils.cfg virtualenv-14.0.6/virtualenv_embedded/python-config virtualenv-14.0.6/virtualenv_embedded/site.py virtualenv-14.0.6/virtualenv_support/ virtualenv-14.0.6/virtualenv_support/__init__.py virtualenv-14.0.6/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/setuptools-20.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-14.0.6/BOOTSTRAPPED + popd ~/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-14.0.6/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning. SNIMissingWarning /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Downloading isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/monitoring/test_disk.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/monitoring/test_disk.py:before 2016-07-01 15:01:31.681365 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/monitoring/test_disk.py:after 2016-07-01 15:08:21.049906 @@ -20,11 +20,7 @@ from twitter.common.dirutil import safe_mkdtemp from twitter.common.quantity import Amount, Data -from apache.thermos.monitoring.disk import ( - DiskCollector, - DiskCollectorProvider, - DuCollector -) +from apache.thermos.monitoring.disk import DiskCollector, DiskCollectorProvider, DuCollector from apache.thermos.monitoring.monitor import TaskMonitor TEST_AMOUNT_1 = Amount(100, Data.MB) I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 1, 2016, 2:51 p.m., Martin Hrabovcin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49512/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 2:51 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > I'd like to get feedback on this patch. > > Thermos currently monitors only sandbox directory but when running with > Docker containerizer process can write data to whole container filesystem. > This patch gives option to monitor whole docker container filesystem. > > Behavior is unchanged if new flag isn't provided. > > > Diffs > ----- > > examples/jobs/docker/hello_docker.aurora > 47adb3932323120e62649f43353719b76c48a963 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > 203fc47d74840889a1192dc867fef5584b704685 > src/main/python/apache/aurora/executor/common/resource_manager.py > b7dc40d8973ec2e5998ab4f6ff988051a70bb1ab > src/main/python/apache/thermos/monitoring/disk.py > 52c5d74fd70b5942ea3ef5101ba3f27bfc98fc21 > src/main/python/apache/thermos/monitoring/resource.py > 53d0ff1a71c27f053c59acca556c35d1e5ac91f0 > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py > fe74bd1d36666ecd89fca1b5b2251202cbbc0f24 > src/test/python/apache/thermos/monitoring/test_disk.py > e57467c61d94d67e6cf6b766c062588235b4b235 > > Diff: https://reviews.apache.org/r/49512/diff/ > > > Testing > ------- > > e2e testing > unit tests > manual testing in Vagrant dev box and on custom dev cluster with option > enabled. > > > Thanks, > > Martin Hrabovcin > >
