> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > src/test/python/apache/aurora/client/cli/test_cron.py, line 111 > > <https://reviews.apache.org/r/49048/diff/7/?file=1440202#file1440202line111> > > > > As an example of many similar test changes: > > > > The additional mock calls are obscuring the original test intend. A > > simple workaround would be to already set a `tier` in the job. > > `get_tier_config` would then no longer need to be called.
Your suggested workaround does not work. If you read through `_get_config_with_production_and_tier()` you would notice that the call on `api.get_tier_configs()` is made whether or not `tier` is already set. The idea is even when `tier` is set, we need to ensure that the selection of `tier` matches that of `production` flag. For example, `tier=preemptible` and `production=true` should result in `production` being revised to `false`. - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142828 ----------------------------------------------------------- On July 20, 2016, 10:56 a.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 10:56 a.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > ------- > > AURORA-1710 Make 'tier' required and remove support for 'production' flag in > Job configuration - CLI changes > > > Diffs > ----- > > RELEASE-NOTES.md 29d224d5596eb060356f1343cf347db79b1ad687 > src/main/python/apache/aurora/client/api/__init__.py > 68baf8fdb90cd26100159401c46c9963c24332b3 > src/main/python/apache/aurora/client/cli/context.py > 9b1511801d031ff48b81c25688a55cb586b8ac66 > src/main/python/apache/aurora/client/config.py > 2fc12559016d406c347adb416a5166cca31c961e > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 2130f1fa71be02a004cdf8e476a270c81a7105d3 > src/test/python/apache/aurora/client/cli/test_context.py > 204ca092adad8bf43c5032a02f61bf303fb0b2fc > src/test/python/apache/aurora/client/cli/test_create.py > 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c > src/test/python/apache/aurora/client/cli/test_cron.py > f3c522ed94a2d774865811ceb546bf9df083c14f > src/test/python/apache/aurora/client/cli/test_plugins.py > a545fece5e2b3e0017a61e1be9ac478372b1f34d > src/test/python/apache/aurora/client/cli/test_restart.py > 967d560e5c7eb0ed85b215fb11d9751b8666acb5 > src/test/python/apache/aurora/client/cli/util.py > 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e > src/test/python/apache/aurora/client/test_config.py > b1a3c1865819899ef19173be0f861783a2631d0a > > Diff: https://reviews.apache.org/r/49048/diff/ > > > Testing > ------- > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > *** OK (All tests passed) *** > > mesos-master start/running, process 26868 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 19m46.324s > user 0m1.496s > sys 0m0.774s > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
