> On July 26, 2016, 7:36 a.m., Joshua Cohen wrote: > > I know this is already landed, but it would be nice to follow this up with > > a test case if possible? > > Mehrdad Nurolahzade wrote: > The logic has two test cases: > (https://github.com/apache/aurora/blob/380307ac1878cb71bc86d2ccd7887192161254cf/src/test/python/apache/aurora/client/test_config.py#L228-L243). > > Joshua Cohen wrote: > Yes, but they weren't failing though? It seems they were not sufficient > to catch this problem.
Alright, I'll add a test case with moustache variables (to prove that it works now with bindings). - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review143525 ----------------------------------------------------------- On July 25, 2016, 7:36 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50432/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 7:36 p.m.) > > > Review request for Aurora, David McLaughlin and Maxim Khutornenko. > > > Bugs: AURORA-1741 > https://issues.apache.org/jira/browse/AURORA-1741 > > > Repository: aurora > > > Description > ------- > > AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710 > > > Diffs > ----- > > src/main/python/apache/aurora/client/config.py > 96cd9ddf77cac449d68537cd652bca03ef87d75d > > Diff: https://reviews.apache.org/r/50432/diff/ > > > Testing > ------- > > ``` > ./build-support/jenkins/build.sh > > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
