> On Aug. 30, 2016, 1:23 a.m., Stephan Erb wrote: > > RELEASE-NOTES.md, lines 41-42 > > <https://reviews.apache.org/r/51506/diff/1/?file=1488293#file1488293line41> > > > > You once recommended to stop all schedules at once when switching to > > Curator, rather than doing this in a rolling fashion. I suppose it is worth > > pointing out here as well. > > > > I would also propose to move the part about the changed default value > > to the 'New/Updates' section. > > Zameer Manji wrote: > +1 > > I'm not sure what happens if you don't do that but it seems that a leader > won't be elected until all of them are on curator.
Done. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147269 ----------------------------------------------------------- On Aug. 29, 2016, 5:37 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51506/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 5:37 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > ------- > > The flag is noted as deprecated for removal in 0.17.0. > > RELEASE-NOTES.md > | 2 ++ > docs/reference/scheduler-configuration.md > | 4 ++-- > examples/vagrant/upstart/aurora-scheduler.conf > | 1 - > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > | 11 +++++++++-- > 4 files changed, 13 insertions(+), 5 deletions(-) > > > Diffs > ----- > > RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 > docs/reference/scheduler-configuration.md > c0c39442725c970e5f9811cd7b4ab3104364c671 > examples/vagrant/upstart/aurora-scheduler.conf > dd60981564286e5b25546737fdd0ce08b0168ed4 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > 36ad18c49c5693031136440ab163070f9ffa9405 > > Diff: https://reviews.apache.org/r/51506/diff/ > > > Testing > ------- > > Locally green: > ``` > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
