----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148095 -----------------------------------------------------------
Master (19866b5) is red with this patch. ./build-support/jenkins/build.sh [1m # Create file stdout for capturing output. We can't use StringIO mock[0m [1m # because TestProcess is running fork.[0m [1m with open(os.path.join(td, 'sys_stdout'), 'w+') as stdout:[0m [1m with open(os.path.join(td, 'sys_stderr'), 'w+') as stderr:[0m [1m with mutable_sys():[0m [1m sys.stdout, sys.stderr = stdout, stderr[0m [1m [0m [1m p = TestProcess('process', 'echo hello world; echo >&2 hello stderr', 0,[0m [1m taskpath, sandbox, logger_destination=LoggerDestination.BOTH)[0m [1m p.start()[0m [1m rc = wait_for_rc(taskpath.getpath('process_checkpoint'))[0m [1m [0m [1m assert rc == 0[0m [1m # Check log files were created in std path with correct content[0m [1m> assert_log_content(taskpath, 'stdout', 'hello world\n')[0m src/test/python/apache/thermos/core/test_process.py:487: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ taskpath = <apache.thermos.common.path.TaskPath object at 0x7f53d5412ed0> log_name = 'stdout' expected_content = 'hello world\n' [1m def assert_log_content(taskpath, log_name, expected_content):[0m [1m log = taskpath.with_filename(log_name).getpath('process_logdir')[0m [1m assert os.path.exists(log)[0m [1m with open(log, 'r') as fp:[0m [1m> assert fp.read() == expected_content[0m [1m[31mE assert '' == 'hello world\n'[0m [1m[31mE + hello world[0m src/test/python/apache/thermos/core/test_process.py:313: AssertionError generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 1 failed, 700 passed, 6 skipped, 1 warnings in 396.57 seconds [0m FAILURE 21:44:37 07:22 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 7, 2016, 9:28 p.m., Kai Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51536/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 9:28 p.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji. > > > Bugs: AURORA-894 > https://issues.apache.org/jira/browse/AURORA-894 > > > Repository: aurora > > > Description > ------- > > - Scheduler updater will not use watch_sec if health check is enabled. > > This feature intends to improve reliability and performance of the Aurora > scheduler job updater by relying on health check status rather than > watch_secs timeout when deciding an individual instance update state. > > See this epic: https://issues.apache.org/jira/browse/AURORA-894 > and the design doc: > https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit# > for more details and background. > > After discussion on Aurora dev list, we decided to keep the watch_secs > infrastructure intact on scheduler side. Our final conclusion is that we > adopt the following implementation: > > 1. If the users want purely health checking driven updates they can set > watch_secs to 0 and enable health checks. > > 2. If they want to have both health checking and time driven updates they can > set watch_secs to the time that they care about, and doing health checks at > STARTING state as well. > > 3. If they just want time driven updates they can disable health checking and > set watch_secs to the time that they care about. > > In this review, there will be only one scheduler change: > Currently scheduler does not accept zero value for watch_secs, we need to > relax this constraint. > > Executor change to do (in a separate review): > The executor starts health check at STARTING, if a successful health check is > performed before initial_interval_sec expires, the executor will sends a > status message for RUNNING. > > > Diffs > ----- > > RELEASE-NOTES.md d79aaadc197697d09a71c83494a01765d6a983d4 > src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java > ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 04551f17999d742c53dfb1b36286b119b448550e > > Diff: https://reviews.apache.org/r/51536/diff/ > > > Testing > ------- > > ./gradlew build > > ./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT" > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > >