----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51664/#review148185 -----------------------------------------------------------
Ship it! lgtm modulo the below. docs/operations/configuration.md (line 32) <https://reviews.apache.org/r/51664/#comment215620> s/pulbic/public docs/operations/configuration.md (line 137) <https://reviews.apache.org/r/51664/#comment215621> "Both the Mesos and Docker containerizers" docs/operations/configuration.md (lines 158 - 159) <https://reviews.apache.org/r/51664/#comment215622> s/to pass// - Joshua Cohen On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51664/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 7:18 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Bugs: AURORA-1640 > https://issues.apache.org/jira/browse/AURORA-1640 > > > Repository: aurora > > > Description > ------- > > Included changes: > > * enabled Docker support in our vagrant box > * consistent example jobs for both containerizers > * short enduser and operator documentation > * shuffled the reference documentation so that it is clear certain > limitations apply only to the Docker containerizer > > > Diffs > ----- > > docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 > docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 > docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 > examples/jobs/docker/hello_docker.aurora > d5611e6b78cb613c04e2fc3df54397ee4401a62e > examples/jobs/hello_docker_image.aurora PRE-CREATION > examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd > examples/vagrant/mesos_config/etc_mesos-slave/image_providers > 7168c0ca4a81e0a1ce2320534015c6692b804b54 > examples/vagrant/mesos_config/etc_mesos-slave/isolation > c36223028513ace26040620b813022accaf0edf3 > > Diff: https://reviews.apache.org/r/51664/diff/ > > > Testing > ------- > > Rendered version available at > https://github.com/StephanErb/aurora/tree/containerizer-docs/docs > > > Thanks, > > Stephan Erb > >