----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51742/#review148280 -----------------------------------------------------------
src/test/python/apache/aurora/executor/test_status_manager.py (line 43) <https://reviews.apache.org/r/51742/#comment215768> I think the param result in the callback fucntion here should be StatusResult as well, not TaskState.Value('TASK_KILLED')? This test callback function is a little bit inconsistent with the callback in status_mananger.py, but I guess it's OK. - Kai Huang On Sept. 8, 2016, 8:07 p.m., Kai Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51742/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 8:07 p.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji. > > > Bugs: AURORA-1225 > https://issues.apache.org/jira/browse/AURORA-1225 > > > Repository: aurora > > > Description > ------- > > Modify the callback function passed to StatusManager to handle more > StatusResult. > > Currently, Aurora executor passes a callback to a status manager. The status > manager periodically polls the status of HealthChecker. When a non-empty > status is deteted, the callback function will shut down the status manager. > > In health check driven updates, the health checker will change its status to > "TASK_RUNNING" when a successful required number of health checks is reached. > Therefore, we need to modify the callback function, so that it won't shutdown > the status manager if the task is in non-exit state like "TASK_RUNNING". > > Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225 > and the design doc: > https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit# > for more details and background. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > ce5ef680f01831cd89fced8969ae3246c7f60cfd > src/main/python/apache/aurora/executor/status_manager.py > 228a99a05f339e21cd7e769a42b9b2276e7bc3fc > src/test/python/apache/aurora/executor/test_status_manager.py > ce4679ba1aa7b42cf0115c943d84663030182d23 > > Diff: https://reviews.apache.org/r/51742/diff/ > > > Testing > ------- > > ./gradlew build > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > >
