> On Sept. 12, 2016, 11:06 a.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > <https://reviews.apache.org/r/51807/diff/1/?file=1496736#file1496736line205> > > > > As an aside, could you file a ticket to clean up the default here? > > Seems useless ATM. > > Joshua Cohen wrote: > Do you mean the rendering of the default value, or the actual default > value for `shiro_realm_modules`? The actual default is not useless, and I > think including the default value is useful as well, but we could improve > `MoreModules#lazilyInstantiated` to override `toString` on the anonymous > `AbstractModule` instance so it will print out the actual module name?
I mean the rendering of the default value. We need to implement `toString` somewhere. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148541 ----------------------------------------------------------- On Sept. 12, 2016, 6:38 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51807/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 6:38 a.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > We plan to open source a very simple Mesos ResourceEstimator and > QosController that supports RAM and CPU oversubscription (ETA ~2 weeks). We > have been using it internally with a patched Aurora version where the > hardcoded `isMesosRevocable` flag of RAM has been set to `true`. This patch > makes this behaviour configurable. > > > Diffs > ----- > > RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 > docs/features/resource-isolation.md > 01c5b407a4964e89741d0f6c72d04ab5dc4c2f87 > docs/operations/configuration.md 90dde574ce517355d2d6045a5ab036c1a3838882 > docs/reference/scheduler-configuration.md > 87d2cded0780ffa34884b52cc049c6a0ad808f0a > src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > 4c102a3d4c4bdd27a1d0536b689acd6257e77788 > > Diff: https://reviews.apache.org/r/51807/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
