> On Sept. 12, 2016, 8:09 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 267 > > <https://reviews.apache.org/r/51712/diff/6/?file=1497449#file1497449line267> > > > > This should send both key and query for both v-1 and v schedulers to > > work correctly.
Done. > On Sept. 12, 2016, 8:09 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, lines 529-533 > > <https://reviews.apache.org/r/51712/diff/6/?file=1497450#file1497450line529> > > > > Are you sure the `detailsList` is going to be set when a response is > > coming from the v-1 scheduler? Even if that was the case, it would be > > completely empty. I'd expect something like this instead: > > ``` > > if detailsList is not None: > > # process detailsList > > else > > # process details > > ``` You are right, dealing with thrift deprecation is new to me and I did not realize this was the case. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148643 ----------------------------------------------------------- On Sept. 12, 2016, 3:26 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51712/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 3:26 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1764 > https://issues.apache.org/jira/browse/AURORA-1764 > > > Repository: aurora > > > Description > ------- > > This extends getJobUpdateDetails to return a list of details instead of being > scoped to a single update. > > > Diffs > ----- > > RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > c5765b70501c101f0535b4eed94e9948c36808f9 > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > 4202f0eec59ef16668fca6b6ebb925335ad5dea1 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 929d021a336c6a3438613c9340c84a1096dc9069 > src/main/python/apache/aurora/client/api/__init__.py > 9149c3018ae58d405f284fcbd4076d251ccc8192 > src/main/python/apache/aurora/client/cli/update.py > d23243dcf93dd82f66b4c8cc4342bd2c8d2adc79 > src/main/resources/scheduler/assets/js/services.js > 315fc17894c2261333715fbb9c45fc02505f2942 > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > a7d1f74acdfe5f58eb822a4d826e920cad53dced > src/test/python/apache/aurora/client/api/test_api.py > 7a0797d5402e931006d4f215e2d9c0dbbd113257 > src/test/python/apache/aurora/client/cli/test_supdate.py > 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 > > Diff: https://reviews.apache.org/r/51712/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >
