----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51980/#review149530 -----------------------------------------------------------
@ReviewBot retry - Dmitriy Shirchenko On Sept. 19, 2016, 6:28 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51980/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 6:28 p.m.) > > > Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1772 > https://issues.apache.org/jira/browse/AURORA-1772 > > > Repository: aurora > > > Description > ------- > > This is a refactor with addition of HttpClient injected into Webhook class as > opposed to previous usage of lower level HtttpURLConnection objects. > Additionally due to peformance issues, it is unncessary to POST entire task > state to webhook endpoint on every scheduler restart so that is removed in > this patch. > > > Diffs > ----- > > build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531 > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > e54aa19d67278fcb5586f07c399f09062f845a18 > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java > e4193f7518e66d210a6d5aae22a9f04e2d4984b3 > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java > eaa70533a64740c74cebf15739b7142e2d3a4d11 > src/main/resources/org/apache/aurora/scheduler/webhook.json > 00787985510d7d415b8074bef06d28b635c78b09 > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > 488eefd14c3e67a41a75c809397c8d19f83cc08a > > Diff: https://reviews.apache.org/r/51980/diff/ > > > Testing > ------- > > Part of reason for refactor is to allow easier testing so cleaner unit tests > were added with more code coverage. > > > Thanks, > > Dmitriy Shirchenko > >
