----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/#review150460 -----------------------------------------------------------
Ship it! Master (4ead189) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 26, 2016, 9:16 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52276/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 9:16 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1783 > https://issues.apache.org/jira/browse/AURORA-1783 > > > Repository: aurora > > > Description > ------- > > Last refactoring of Webhook did not correctly close out connections so some > webhook requests would not complete. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > 66c134488f159fc25cfb2c1755b8fa23fbbdb613 > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java > 71aae983e9c2c34e106a931e4d25691977684b11 > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > 6f37baaefb2910e688d7df90f3e94fc282cfb6b6 > > Diff: https://reviews.apache.org/r/52276/diff/ > > > Testing > ------- > > Verified in vagrant + added unit tests. > > > Thanks, > > Dmitriy Shirchenko > >
