----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52300/#review150864 -----------------------------------------------------------
lgtm overall. Just two small changes and it's gtg... src/main/python/apache/aurora/client/cli/options.py (lines 261 - 264) <https://reviews.apache.org/r/52300/#comment218944> I see the benefit of changing the help message for the ssh case, since the behavior is different if INSTANCES is not specified. Other than the help message, this is identical to `INSTANCES_SPEC_ARGUMENT` however. Perhaps create a helper function that takes the help text and returns the `CommandOption` that can be reused by both of these? src/test/python/apache/aurora/client/cli/test_task.py (line 179) <https://reviews.apache.org/r/52300/#comment218947> Can you add a test case for the case where no instance is specified that asserts the `getTasksStatus` api call is made with the `instanceIds` param on the query not set? - Joshua Cohen On Sept. 29, 2016, 5:30 a.m., JING CHEN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52300/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 5:30 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1110 > https://issues.apache.org/jira/browse/AURORA-1110 > > > Repository: aurora > > > Description > ------- > > Running task ssh without an instance should pick the random instance > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/options.py > 1245ff15a69a4b4347672f7b556985521e813a00 > src/main/python/apache/aurora/client/cli/task.py > a8a4edcfda8d879fcc4401bb8f5223de3ee5376d > src/test/python/apache/aurora/client/cli/test_task.py > d2233b67b37f8b34fae62372aa5d95e0a2e827b5 > > Diff: https://reviews.apache.org/r/52300/diff/ > > > Testing > ------- > > verified in vagrant > > > Thanks, > > JING CHEN > >
