----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151376 -----------------------------------------------------------
Thanks for the patch and sorry for the massiv delay. Would be great if we could get this into a shape so that it integrates with Aurora's client auth mechanism more naturally: * Interface that we'd need to implement: https://github.com/apache/aurora/blob/b24619b28c4dbb35188871bacd0091a9e01218e3/src/main/python/apache/aurora/common/auth/auth_module.py#L19 * `AuthBase` is part of request http://docs.python-requests.org/en/master/user/authentication/#authentication Looks like for your cookie usecase, we'd then need a custom `AuthBase` implementation that sets cookies if available. - Stephan Erb On Oct. 4, 2016, 9:22 p.m., Giulio Eulisse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51893/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 9:22 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > This allows aurora client to connect to servers which are behind a > frontend which expects some sort of cookie to autheticate and authorize > users. > > A cookie_jar option can be specified in the `~/.aurora/clusters.json` > to specify a file where the cookie jar is located. Such a cookie jar, > in MozillanCookieJar format, will be used to create the session and > therefore all the subsequent requests will use it. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > cbdb50ae409b70a35a03405f969d02a6145c9c53 > > Diff: https://reviews.apache.org/r/51893/diff/ > > > Testing > ------- > > $ cat ~/aurora/clusters.json > [ > { > "name": "build", > "scheduler_uri": "https://aliaurora.cern.ch";, > "auth_mechanism": "UNAUTHENTICATED", > "cookie_jar": "~/.aurora-token" > } > ] > $ dist/aurora.pex quota get build/root > > > Thanks, > > Giulio Eulisse > >
