> On Oct. 4, 2016, 7:17 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/api/updater_util.py, line 39 > > <https://reviews.apache.org/r/52453/diff/2/?file=1519298#file1519298line39> > > > > "Watch seconds should not be negative."
sure. Will do. - Kai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151372 ----------------------------------------------------------- On Oct. 4, 2016, 12:42 a.m., Kai Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52453/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 12:42 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-894 > https://issues.apache.org/jira/browse/AURORA-894 > > > Repository: aurora > > > Description > ------- > > - Add support for receiving a new HealthCheckConfig attribute > "min_consecutive_successes" in health checker. > - Add an entry in release note that describes the health check driven update > feature. > > This patch is related to https://reviews.apache.org/r/52094/, in which I > added a new configuration value "min_consecutive_successes" in > HealthCheckConfig. > > > Diffs > ----- > > RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd > src/main/python/apache/aurora/client/api/updater_util.py > c649316edb876565c92cc90c9f030e153c008924 > src/main/python/apache/aurora/executor/common/health_checker.py > 03fbffdc3862a94c2ba42c9b9e8f2be4094129b8 > > Diff: https://reviews.apache.org/r/52453/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > ./pants test.pytest src/test/python/apache/aurora/executor:: > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Kai Huang > >
