----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54624/#review159690 -----------------------------------------------------------
Master (38b9311) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 20, 2016, 9:33 a.m., Jing Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54624/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 9:33 a.m.) > > > Review request for Aurora, Joshua Cohen, Mehrdad Nurolahzade, Stephan Erb, > and Zameer Manji. > > > Bugs: AURORA-1838 > https://issues.apache.org/jira/browse/AURORA-1838 > > > Repository: aurora > > > Description > ------- > > Expose stats on ZooKeeper connection state > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > 999a542796858dcfe9e31601c47239189043fd52 > > Diff: https://reviews.apache.org/r/54624/diff/ > > > Testing > ------- > > http://192.168.33.7:8081/vars > ``` > zk_connection_state_CONNECTED 1 > zk_connection_state_CONNECTED_counter 1 > zk_connection_state_LOST 0 > zk_connection_state_LOST_counter 0 > zk_connection_state_READ_ONLY 0 > zk_connection_state_READ_ONLY_counter 0 > zk_connection_state_RECONNECTED 0 > zk_connection_state_RECONNECTED_counter 0 > zk_connection_state_SUSPENDED 0 > zk_connection_state_SUSPENDED_counter 0 > ``` > > * zk_connection_state_STATE shows 1 if STATE is current connection state, > otherwise 0. > * zk_connection_state_STATE_counter represents occurence times of the STATE > since scheduler state > > > Thanks, > > Jing Chen > >
