----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159891 -----------------------------------------------------------
src/main/python/apache/aurora/admin/aurora_admin.py (line 51) <https://reviews.apache.org/r/54957/#comment230945> Since we are merely exposing control over something that is already present, can we just call this `--retry` and default to `true`. I feel like it will be easier to read. src/main/python/apache/aurora/admin/aurora_admin.py (line 55) <https://reviews.apache.org/r/54957/#comment230942> This is not true. We still retry on timeouts. It is misleading to have a switch `--no-retry` and still retry on some situtations. Maybe it should be all or nothing. src/test/python/apache/aurora/client/api/test_scheduler_client.py (line 250) <https://reviews.apache.org/r/54957/#comment230946> This the same test as above isn't it. Can we test when we are no requesting retries? - Santhosh Kumar Shanmugham On Dec. 21, 2016, 4:06 p.m., Karthik Anantha Padmanabhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54957/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 4:06 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, Santhosh Kumar > Shanmugham, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This diff adds an option to not retry api calls to the scheduler. For some of > the non-idempotent operations we would like to not automatically retry. This > patch makes this functionality available only to the `schedule_backup_now` > command. > > If there is consensus, this can be added to all commands as well. > > > Diffs > ----- > > src/main/python/apache/aurora/admin/admin.py > 070c348d2ca5db1edecf832efd9aa5481bddaa4b > src/main/python/apache/aurora/admin/aurora_admin.py > fbebbab8c827b5695042d18770d850e31fc38122 > src/main/python/apache/aurora/client/api/__init__.py > e1dde638bd1d686269fbcd88cb083a52e7f5dbfc > src/main/python/apache/aurora/client/api/scheduler_client.py > 9bbfece012e48e0b1752bbefd25c89e04d312cf6 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef > > Diff: https://reviews.apache.org/r/54957/diff/ > > > Testing > ------- > > * Manuall testing > * ./build-support/jenkins/build.sh passes > > > Thanks, > > Karthik Anantha Padmanabhan > >
