> On Dec. 22, 2016, 10:04 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java, > > line 87 > > <https://reviews.apache.org/r/54967/diff/1/?file=1591015#file1591015line87> > > > > I have just noticed this is holding the storage lock. Would it make > > sense to export the timing here as well? (like in > > https://reviews.apache.org/r/54959/) > > Mehrdad Nurolahzade wrote: > The timing information as I have indicated on the ticket > [AURORA-1856](https://issues.apache.org/jira/browse/AURORA-1856) is being > collected in `DbJobUpdateStore.pruneHistory()`. > > Mehrdad Nurolahzade wrote: > Just to be clear, there is a minor difference between your suggested > timing stats (on runs) and the one already exposed through > `DbJobUpdateStore.pruneHistory()`. The former would also include lock wait > time, while the later only exposes operation time. > > We are already exposing stats on lock wait time > (`log_storage_write_lock_wait`). Therefore, I don't see an immediate need to > add an instrument here that also measures lock wait time (unless future > analysis proves me wrong).
Thanks for the explanation. - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/#review159936 ----------------------------------------------------------- On Dec. 22, 2016, 8:37 a.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54967/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 8:37 a.m.) > > > Review request for Aurora, David McLaughlin and Joshua Cohen. > > > Bugs: AURORA-1856 > https://issues.apache.org/jira/browse/AURORA-1856 > > > Repository: aurora > > > Description > ------- > > AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > 6ab39ca0a64dfab9fe2fdec79fef1b4d320b6dc6 > > src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java > 20f790ef4d04cd8aaa7cdab4442040a31fa72838 > > Diff: https://reviews.apache.org/r/54967/diff/ > > > Testing > ------- > > > Thanks, > > Mehrdad Nurolahzade > >
