----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55536/ -----------------------------------------------------------
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Bugs: AURORA-1875 https://issues.apache.org/jira/browse/AURORA-1875 Repository: aurora Description ------- Now the selected thrift is checked both for the proper version and support of the gen langs Aurora requires. In addition, all thrifts on the `PATH` are and an existing locally built thrift is always verified to protect Aurora thrift requirement changes (if we ever add a gen lang again). build-support/thrift/thriftw | 54 +++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 42 insertions(+), 12 deletions(-) Diffs ----- build-support/thrift/thriftw 1185298b902b5f1075816d0113ddc34dd4c26a89 Diff: https://reviews.apache.org/r/55536/diff/ Testing ------- I have thrift latest (0.10.0) installed as a system package: ``` $ ./build-support/thrift/thriftw 0.10.0 --which /usr/bin/thrift $ ./build-support/thrift/thriftw 0.10.0 -help 2>&1 | grep Swift swift (Swift): $ ./build-support/thrift/thriftw 0.9.1 --which /home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift $ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep Swift $ ``` I also edited the "java (Java)" gen identifier to "java (Java2)" and observed the script forcing a clean recompile of 0.9.1 with a subsequent failure to find a compatible thrift. Thanks, John Sirois